What the ELSE?

public SessionStateChangeResult StateChangeFlag
{
    get
    {
        if ( this.HasDeletedSession )
        {
            return SessionStateChangeResult.SourceMerged;
        }
        else
        {
            if ( this.HasMovedSession )
            {
                return SessionStateChangeResult.SourceMoved;
            }
            else
            {
                if ( this.HasNewSession )
                {
                    return SessionStateChangeResult.SourceUpdateNewDest;
                }
                else
                {
                    if ( this.HasUpdates )
                    {
                        return SessionStateChangeResult.SourceUpdateDestUpdate;
                    }
                    else
                    {
                        return SessionStateChangeResult.Invalid;
                    }
                }
            }
        }
    }
}

Logic = hard

 d.results.length > 0 ? this.existingAddresses = true : this.existingAddresses = false

Variable abuse

let checkForHighlight = true;

for (let rows of this.tableBody.nativeElement.children)
{
    if (checkForHighlight && rows.classList.contains('alert-warning'))

    {
        checkForHighlight = false;
    }
}

if (!checkForHighlight)

{
    this.showQuantityWarning = true;
}

else

{
    this.showQuantityWarning = false;
}

return?

That's 400 lines of code in an if.

 

What's a bool?

If ValidAccess = False Then
    ...
ElseIf ValidAccess = True Then
    ...
End If

Why! Why! Why!

public override bool Validate()
{
    bool bValidate = false;

    try
    {
        bValidate = (EOID > 0 ? true : false);
    }
    catch (Exception ex)
    {
        Utilities.LogError(ex.Message, "AbsentHoursBL");
        throw;
    }

    return bValidate;
}

WOW.... That's efficient

CREATE PROCEDURE dbo.proFormDropDown 
(@FormType As VARCHAR(5))
AS

SET NOCOUNT ON

CREATE TABLE #tbl_hold_menu (
menu_num VARCHAR(2),
menu_name VARCHAR(20),
form_type CHAR(1))

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT  dept_id, dept_desc,dept_menu_type 
FROM tbl_dept 
ORDER BY dept_desc

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT job_id, job_title, job_menu_type FROM tbl_job
  WHERE job_menu_type <>'0'
ORDER BY job_menu_type

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT shift_num, shift_name, menu_type 
FROM tbl_shift
ORDER BY shift_num 

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT work_team_id, work_team_name, 'T'
FROM tbl_work_team
ORDER BY work_team_name

SELECT * FROM  #tbl_hold_menu
WHERE form_type = @FormType
ORDER BY form_type

DROP TABLE  #tbl_hold_menu