Pick a property name already!

     const getLast4 = (c: any): string | undefined =>

        {

            if (c?.lastFourDigitsAccountNum && /^\d{4}$/.test(String(c.lastFourDigitsAccountNum)))

            {

                return String(c.lastFourDigitsAccountNum);

            }

            let v =

                c?.lastFourDigits ??

                c?.lastFour ??

                c?.last4 ??

                c?.cardLast4 ??

                c?.accountLast4 ??

                c?.last_digits ??

                c?.lastDigits ??

                undefined;

            if (!v || String(v).trim() === "")

            {

                const cand = [

                    c?.cardNumber,

                    c?.pan,

                    c?.maskedPan,

                    c?.maskedCard,

                    c?.accountNumber,

                    c?.maskedAccount,

                ].filter(Boolean);

                for (const s of cand)

                {

                    const m = String(s).match(/(\d{4})\D*$/);

                    if (m) { v = m[1]; break; }

                }

            }

            return v && /^\d{4}$/.test(String(v)) ? String(v) : undefined;

        };

What the ELSE?

public SessionStateChangeResult StateChangeFlag
{
    get
    {
        if ( this.HasDeletedSession )
        {
            return SessionStateChangeResult.SourceMerged;
        }
        else
        {
            if ( this.HasMovedSession )
            {
                return SessionStateChangeResult.SourceMoved;
            }
            else
            {
                if ( this.HasNewSession )
                {
                    return SessionStateChangeResult.SourceUpdateNewDest;
                }
                else
                {
                    if ( this.HasUpdates )
                    {
                        return SessionStateChangeResult.SourceUpdateDestUpdate;
                    }
                    else
                    {
                        return SessionStateChangeResult.Invalid;
                    }
                }
            }
        }
    }
}

Logic = hard

 d.results.length > 0 ? this.existingAddresses = true : this.existingAddresses = false

Variable abuse

let checkForHighlight = true;

for (let rows of this.tableBody.nativeElement.children)
{
    if (checkForHighlight && rows.classList.contains('alert-warning'))

    {
        checkForHighlight = false;
    }
}

if (!checkForHighlight)

{
    this.showQuantityWarning = true;
}

else

{
    this.showQuantityWarning = false;
}

return?

That's 400 lines of code in an if.

 

What's a bool?

If ValidAccess = False Then
    ...
ElseIf ValidAccess = True Then
    ...
End If

Why! Why! Why!

public override bool Validate()
{
    bool bValidate = false;

    try
    {
        bValidate = (EOID > 0 ? true : false);
    }
    catch (Exception ex)
    {
        Utilities.LogError(ex.Message, "AbsentHoursBL");
        throw;
    }

    return bValidate;
}

WOW.... That's efficient

CREATE PROCEDURE dbo.proFormDropDown 
(@FormType As VARCHAR(5))
AS

SET NOCOUNT ON

CREATE TABLE #tbl_hold_menu (
menu_num VARCHAR(2),
menu_name VARCHAR(20),
form_type CHAR(1))

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT  dept_id, dept_desc,dept_menu_type 
FROM tbl_dept 
ORDER BY dept_desc

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT job_id, job_title, job_menu_type FROM tbl_job
  WHERE job_menu_type <>'0'
ORDER BY job_menu_type

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT shift_num, shift_name, menu_type 
FROM tbl_shift
ORDER BY shift_num 

INSERT INTO  #tbl_hold_menu(menu_num, menu_name, form_type)
SELECT work_team_id, work_team_name, 'T'
FROM tbl_work_team
ORDER BY work_team_name

SELECT * FROM  #tbl_hold_menu
WHERE form_type = @FormType
ORDER BY form_type

DROP TABLE  #tbl_hold_menu

Hard-coded Hell!

Sub WritePosition()

If fPositionID = "0" Then

Response.Write "<OPTION VALUE='0' SELECTED>Select Type </OPTION>"

Response.Write "<OPTION VALUE='F/T'>Full Time</OPTION>"

Response.Write "<OPTION VALUE='P/T'>Part Time</OPTION>"

Response.Write "<OPTION VALUE='Temp'>Agency Hires</OPTION>"

ElseIf fPositionID = "F/T" Then

Response.Write "<OPTION VALUE='0'>Select Type </OPTION>"

Response.Write "<OPTION VALUE='F/T' SELECTED>Full Time</OPTION>"

Response.Write "<OPTION VALUE='P/T'>Part Time</OPTION>"

Response.Write "<OPTION VALUE='Temp'>Agency Hires</OPTION>"

ElseIf fPositionID = "P/T" Then

Response.Write "<OPTION VALUE='0'>Select Type </OPTION>"

Response.Write "<OPTION VALUE='F/T'>Full Time</OPTION>"

Response.Write "<OPTION VALUE='P/T'SELECTED>Part Time</OPTION>"

Response.Write "<OPTION VALUE='Temp'>Agency Hires</OPTION>"

Else

Response.Write "<OPTION VALUE='0'>Select Type </OPTION>"

Response.Write "<OPTION VALUE='F/T'>Full Time</OPTION>"

Response.Write "<OPTION VALUE='P/T'>Part Time</OPTION>"

Response.Write "<OPTION VALUE='Temp' SELECTED>Agency Hires</OPTION>"

End If

End Sub

Another logic headscratcher

If IsNumeric(CurrentPunchID) = True And CurrentBehavior = "B" Then
  ...
ElseIf IsNumeric(CurrentPunchID) = True And CurrentBehavior <> "B" Then
  ...
End If

Logic Hard

<SCRIPT LANGUAGE="JavaScript">
if (!parent.fraLogout == false) {
    parent.fraLogout.location.reload(true);
}
else if (!opener.parent.fraLogout == false) {
    opener.parent.fraLogout.location.reload(true);
}
</SCRIPT>

nuLoL

return ((Request.Cookies["UserSettings"]["GUID"] != null ? Request.Cookies["UserSettings"]["GUID"] : null));

This was an answer to how to remove a script tag that was dynamically added. 😧

---

var flag1=0,flag2=0;

$(window).resize(function()
{
    if ($(window).width() < 480)
    {
        flag1++;
        console.log(flag1);
        flag2=0;  
    }
    else 
        if($(window).width() > 480)
        {
            flag2++;
            console.log(flag2);
            flag1=0;
        }

    if(flag1==1)
    {
        $("body").append("<script class='abc' src='custom.js'/>");
    }
    else
        if(flag2==1)
        {
            $(".abc").remove();
        }
});

Year we go!

She really couldn't think of another way to count down a year...?

---

echo '<option value="'.date('Y').'">'.date('Y').'</option>';
for ($i=1; $i<=100; $i++) {
   $year_wanted='-'.$i.' year';
   $year_inpast=date('Y',strtotime($year_wanted));
   echo '<option value="'.$year_inpast.'">'.$year_inpast.'</option>';
}

No problems here

if ( count($set2) >= 1 )
{
    $test = 0;
}
else
{
    $test = 0;
}

They really wanted an array

$data = array();
$data = array(
    'patient_id' => $id,
    'video_id' => $videoid,
    'created_date' => $date . ' ' . $time,
    'created_by' => 0,
    'sch_id' => $schid
);

if ( is_array($data) !== false )
{
...